Merged
Conversation
This allows us to remove the `console-log-level` dependency.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the console-log-level logger with the native @actions/core logger in the API client, allowing the removal of the console-log-level dependency. Additionally, the PR improves the check-node-modules.sh script to handle more installation scenarios.
Key changes:
- Switched from
console-log-levelto@actions/corefor Octokit logging - Removed the
console-log-leveldependency from package.json - Enhanced the
check-node-modules.shscript with additional checks
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/api-client.ts | Replaced console-log-level logger with Actions core logger using spread syntax and aliased warn to core.warning |
| package.json | Removed console-log-level dependency |
| scripts/check-node-modules.sh | Added checks for missing node_modules, outdated package.json, and improved messaging |
| lib/*.js (multiple files) | Generated JavaScript files reflecting the TypeScript changes and dependency removal |
mbg
previously approved these changes
Oct 28, 2025
Comment on lines
52
to
55
| log: { | ||
| ...core, | ||
| warn: core.warning, | ||
| }, |
Member
There was a problem hiding this comment.
Minor: it might be good to set all the properties explicitly rather than include the entire core object, in case it ever changes. We'd probably want to know if that happens.
mbg
approved these changes
Oct 28, 2025
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to remove the
console-log-leveldependency.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-scanning).analysis-kinds: code-quality).upload-sarif).How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist